Electrum: fixes and improvements #924
Merged
+52
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We connect to a random server we're not already connected to.
If was a bit short and sometimes failed on travis.
On testnet some Electrum servers are not compliant with the protocole version they advertise and will return responses formatted with the 1.0 rules.
And add a specific test for the function that picks the next address to connect to.
pm47
approved these changes
Mar 29, 2019
dpad85
pushed a commit
that referenced
this pull request
Apr 4, 2019
* Electrum: Update mainnet servers list * Electrum: make pool address selection more readable We connect to a random server we're not already connected to. * Electrum Tests: increase "wait for ready" test timeout If was a bit short and sometimes failed on travis. * Electrum: better parsing of invalid responses On testnet some Electrum servers are not compliant with the protocole version they advertise and will return responses formatted with 1.0 rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mainnet server list, properly deal with nodes that do not comply with the version of the protocol that they advertise, and increase timeout for our client pool test (which sometimes fails on travis).